From d61086ff5f1e1b9f1c12f0b44e81a2f679e42e55 Mon Sep 17 00:00:00 2001 From: Christian Manivong Date: Tue, 6 Oct 2026 12:27:02 +0200 Subject: [PATCH] feat: declare that upgrading everything must be a full upgrade on OpenMediaVault A plain apt-get upgrade holds back OMV's own packages and the kernel; omv-upgrade is a dist-upgrade. netOrk reads FULL_UPGRADE when it upgrades the host (MVP 5). --- napalm_openmediavault/openmediavault.py | 4 ++++ tests/test_full_upgrade.py | 11 +++++++++++ 2 files changed, 15 insertions(+) create mode 100644 tests/test_full_upgrade.py diff --git a/napalm_openmediavault/openmediavault.py b/napalm_openmediavault/openmediavault.py index 7fbe13d..5f417a5 100644 --- a/napalm_openmediavault/openmediavault.py +++ b/napalm_openmediavault/openmediavault.py @@ -53,6 +53,10 @@ class OpenMediaVaultDriver(StorageDriver, LinuxDriver): TYPE_LABEL = "Storage" DRIVER_NAME = "openmediavault" + #: "Upgrade everything" must be a full upgrade: OMV's own packages and the + #: kernel are held back by a plain ``apt-get upgrade`` (``omv-upgrade`` is a + #: dist-upgrade). netOrk reads this when it upgrades the host. + FULL_UPGRADE = True driver_name = "openmediavault" SSH_FINGERPRINT = [ FingerprintRule("debian", weight=4.0), diff --git a/tests/test_full_upgrade.py b/tests/test_full_upgrade.py new file mode 100644 index 0000000..eaffdf7 --- /dev/null +++ b/tests/test_full_upgrade.py @@ -0,0 +1,11 @@ +"""OMV says that "upgrade everything" must be a full upgrade on it. + +A plain ``apt-get upgrade`` holds back OMV's own packages and the kernel; +``omv-upgrade`` runs a dist-upgrade. netOrk reads ``FULL_UPGRADE`` to choose. +""" + +from napalm_openmediavault.openmediavault import OpenMediaVaultDriver + + +def test_a_full_upgrade_is_declared(): + assert OpenMediaVaultDriver.FULL_UPGRADE is True