NAPALM/napalm-qnap-qts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: hand the container engine connection Container Station's docker #4

Merged
christianmanivong merged 1 commits from feat/container-engine-binary into main 2026-10-07 16:10:45 +00:00
Conversation 0 Commits 1 Files Changed 4
+43 -3
christianmanivong commented 2026-10-07 15:59:55 +00:00
Owner
Copy Link
Copy Source

_container_engine_binary("docker") returns the Container Station path that open() already discovers, so open_container_engine("docker") from NAPALM/napalm-device-types#18 reaches it although docker is not on PATH under QTS. Callers pass arguments only and never see the path (NetOrk/netork#765, phase 1 = netork#769).

Tests: TestContainerEngineBinary (discovered path, open_api() runs <path> system dial-stdio, fallback to docker); suite 41 passed, 1 xfailed.

Depends on NAPALM/napalm-device-types#18 and NAPALM/napalm-linux#18 (CI installs both from main).

Priority: P3

Refs NAPALM/napalm-device-types#17

`_container_engine_binary("docker")` returns the Container Station path that `open()` already discovers, so `open_container_engine("docker")` from NAPALM/napalm-device-types#18 reaches it although docker is not on PATH under QTS. Callers pass arguments only and never see the path (NetOrk/netork#765, phase 1 = netork#769). Tests: `TestContainerEngineBinary` (discovered path, `open_api()` runs `<path> system dial-stdio`, fallback to `docker`); suite 41 passed, 1 xfailed. **Depends on NAPALM/napalm-device-types#18 and NAPALM/napalm-linux#18** (CI installs both from main). Priority: P3 Refs NAPALM/napalm-device-types#17
christianmanivong added 1 commit 2026-10-07 15:59:55 +00:00
feat: hand the container engine connection Container Station's docker
CI / test (3.11) (pull_request) Successful in 27s
Details
CI / test (3.12) (pull_request) Successful in 30s
Details
CI / test (3.10) (push) Successful in 29s
Details
CI / test (3.11) (push) Successful in 27s
Details
CI / test (3.12) (push) Successful in 28s
Details
CI / test (3.10) (pull_request) Successful in 29s
Details
5838685690 
napalm-device-types 2.6.0 opens a host's container engine through
`open_container_engine()`, and asks the driver for the binary through
`_container_engine_binary()`. Under QTS docker is not on PATH; the hook
now returns the path `open()` already discovers, so the Engine API stream
(`<path> system dial-stdio`) and the CLI reach Container Station while
callers only pass arguments (NetOrk/netork#765).

Version 0.2.0, requires napalm-device-types >= 2.6.0 and
napalm-linux >= 0.2.0.

Refs NAPALM/napalm-device-types#17
christianmanivong merged commit 39532471b7 into main 2026-10-07 16:10:45 +00:00
christianmanivong deleted branch feat/container-engine-binary 2026-10-07 16:10:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-qnap-qts#4