NAPALM/napalm-qnap-qts
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor!: drop the _docker_bin override #5

Merged
christianmanivong merged 1 commits from chore/drop-legacy-docker into main 2026-10-08 06:48:37 +00:00
Conversation 0 Commits 1 Files Changed 5
+23 -15
christianmanivong commented 2026-10-08 06:43:58 +00:00
Owner
Copy Link
Copy Source

napalm-linux 0.3.0 (NAPALM/napalm-linux#20) drops the Docker CLI methods this override served.

  • _container_engine_binary("docker") now returns Container Station's path itself. That is all netOrk needs, since it reaches the engine through open_container_engine (NetOrk/netork#765, phase 9).
  • README: the capability table and the Docker section describe the engine access instead of get_docker_info.
  • Requires napalm-linux >= 0.3.0. Version 0.3.0.
  • 40 tests pass against napalm-linux 0.3.0.
napalm-linux 0.3.0 (NAPALM/napalm-linux#20) drops the Docker CLI methods this override served. - `_container_engine_binary("docker")` now returns Container Station's path itself. That is all netOrk needs, since it reaches the engine through `open_container_engine` (NetOrk/netork#765, phase 9). - README: the capability table and the Docker section describe the engine access instead of `get_docker_info`. - Requires napalm-linux >= 0.3.0. Version 0.3.0. - 40 tests pass against napalm-linux 0.3.0.
christianmanivong added 1 commit 2026-10-08 06:43:58 +00:00
refactor!: drop the _docker_bin override
CI / test (3.10) (pull_request) Successful in 29s
Details
CI / test (3.11) (pull_request) Successful in 27s
Details
CI / test (3.12) (pull_request) Successful in 29s
Details
CI / test (3.10) (push) Successful in 28s
Details
CI / test (3.11) (push) Successful in 26s
Details
CI / test (3.12) (push) Successful in 28s
Details
912469bdc0 
napalm-linux 0.3.0 drops the Docker CLI methods the override served.
_container_engine_binary("docker") returns Container Station's path
itself, which is all netOrk needs: it reaches the engine through
open_container_engine (NetOrk/netork#765, phase 9).

Requires napalm-linux >= 0.3.0. Version 0.3.0.
christianmanivong merged commit 088d47f47c into main 2026-10-08 06:48:37 +00:00
christianmanivong deleted branch chore/drop-legacy-docker 2026-10-08 06:48:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-qnap-qts#5