refactor!: drop the Docker CLI methods #20

2026-10-08T06:41:41Z

christianmanivong commented

2026-10-08 06:41:41 +00:00

get_docker_info(), get_docker_outdated(), reconstruct_docker_run() and the _docker_bin() hook go, together with the image-ID helpers they used.

netOrk reads and handles containers itself over the Engine API, through open_container_engine() (NetOrk/netork#765). Since phase 9 (NetOrk/netork#776) it no longer calls these methods.

run_device_action("fix_docker_permissions") stays: letting the login user use Docker is an OS action.

Breaking, so the version goes to 0.3.0.
The tests for the _docker_bin hook are replaced by a test that the methods are gone and that engine access and the permission fix stay.
133 tests pass.

`get_docker_info()`, `get_docker_outdated()`, `reconstruct_docker_run()` and the `_docker_bin()` hook go, together with the image-ID helpers they used. netOrk reads and handles containers itself over the Engine API, through `open_container_engine()` (NetOrk/netork#765). Since phase 9 (NetOrk/netork#776) it no longer calls these methods. `run_device_action("fix_docker_permissions")` stays: letting the login user use Docker is an OS action. - Breaking, so the version goes to 0.3.0. - The tests for the `_docker_bin` hook are replaced by a test that the methods are gone and that engine access and the permission fix stay. - 133 tests pass.

christianmanivong added 1 commit 2026-10-08 06:41:41 +00:00

refactor!: drop the Docker CLI methods

CI / test (3.10) (push) Successful in 41s

Details

CI / test (3.11) (push) Successful in 37s

Details

CI / test (3.12) (push) Successful in 38s

Details

CI / test (3.10) (pull_request) Successful in 37s

Details

CI / test (3.11) (pull_request) Successful in 36s

Details

CI / test (3.12) (pull_request) Successful in 38s

Details

3333d8e8f5

get_docker_info(), get_docker_outdated(), reconstruct_docker_run() and
the _docker_bin() hook go, with the image-ID helpers. netOrk reads and
handles containers over the Engine API through open_container_engine()
since NetOrk/netork#765 and no longer calls them (phase 9). The
fix_docker_permissions action stays: it is an OS action.

Version 0.3.0.

christianmanivong merged commit 3a76b6d47f into master

2026-10-08 06:43:47 +00:00

christianmanivong deleted branch chore/drop-legacy-docker

2026-10-08 06:43:47 +00:00

christianmanivong referenced this pull request from NAPALM/napalm-qnap-qts

2026-10-08 06:43:58 +00:00

refactor!: drop the _docker_bin override #5

christianmanivong referenced this pull request from NAPALM/napalm-device-types

2026-10-08 06:48:47 +00:00

refactor!: drop the Docker model #21

christianmanivong referenced this issue from a commit

2026-10-08 06:57:38 +00:00