Merge pull request 'ci: run the tests and build the package on every push and pull request' (#3) from ci/workflow into main

The same job as napalm-fritzbox and napalm-opnsense: Python 3.10, 3.11 and
3.12, pytest, then wheel and sdist. napalm-device-types comes from
git.netork.io first, because PyPI has an unrelated package of that name.

napalm-linux, which this driver builds on, is installed from git as well:
it is not on PyPI either.

.github/workflows/ci.yml

@@ -0,0 +1,50 @@
+name: CI
+
+on:
+  push:
+    branches: ["**"]
+  pull_request:
+    branches: ["**"]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ["3.10", "3.11", "3.12"]
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
+          cache: pip
+
+      - name: Install package with dev extras
+        run: |
+          python -m pip install --upgrade pip
+          # napalm-device-types lives in git.netork.io/NAPALM, not on PyPI: without this
+          # pip looks there, finds an unrelated 0.1.0 and the job dies before any test.
+          python -m pip install "napalm-device-types @ git+https://git.netork.io/NAPALM/napalm-device-types.git"
+          # napalm-linux, which this driver builds on, is not on PyPI either.
+          python -m pip install "napalm-linux @ git+https://git.netork.io/NAPALM/napalm-linux.git"
+          python -m pip install -e ".[dev]"
+
+      - name: Run unit tests
+        run: |
+          python -m pytest -q --tb=short
+
+      - name: Build wheel and sdist
+        run: |
+          python -m pip install build
+          python -m build
+
+      - name: Upload dist artifacts
+        # v4 refuses to run on Gitea ("not currently supported on GHES").
+        uses: actions/upload-artifact@v3
+        with:
+          name: dist-${{ matrix.python-version }}
+          path: dist/*

napalm_qnap_qts/qnap_qts.py

@@ -68,6 +68,17 @@ class QnapQtsDriver(StorageDriver, HypervisorDriver, LinuxDriver):
     driver_name = "qnap_qts"
     NETMIKO_DEVICE_TYPE = "linux"
 
+    #: QTS has no systemd, so the systemctl actions LinuxDriver inherits from
+    #: napalm-device-types' SystemdServicesMixin would fail on every unit. None
+    #: makes every "can it control services?" check -- is ``manage_service``
+    #: callable -- answer no, rather than offering buttons that cannot work.
+    manage_service = None  # type: ignore[assignment]
+    #: The same for updates: QTS has no apt, dnf or opkg, and QPKG updates are
+    #: not implemented. netOrk leaves a driver without them out of patching.
+    get_available_updates = None  # type: ignore[assignment]
+    refresh_available_updates = None  # type: ignore[assignment]
+    apply_updates = None  # type: ignore[assignment]
+
     SNMP_OBJECT_ID_PREFIX = QNAP_ENTERPRISE_OID
     SNMP_FINGERPRINT = [
         FingerprintRule("qnap", weight=9.0),

tests/test_qnap_qts.py

@@ -182,3 +182,23 @@ class TestDockerBinDiscovery:
     def test_docker_bin_hook_returns_the_discovered_path(self, driver):
         driver._docker_path = "/opt/docker"
         assert driver._docker_bin() == "/opt/docker"
+
+
+def test_services_cannot_be_controlled():
+    """QTS has no systemd: the systemctl actions inherited from LinuxDriver would
+    fail on every unit, so the driver says it cannot control services at all --
+    which is what every capability check asks (is ``manage_service`` callable?)."""
+    from napalm_linux.linux import LinuxDriver
+
+    assert callable(getattr(LinuxDriver, "manage_service", None))
+    assert not callable(getattr(QnapQtsDriver, "manage_service", None))
+
+
+
+def test_updates_are_not_read_or_applied_here():
+    """QTS has no apt, dnf or opkg: the readers inherited from LinuxDriver find no
+    package manager, and QPKG updates are not implemented. Saying so keeps QNAP out
+    of netOrk's patch groups and compliance report, which ask whether these
+    methods are callable."""
+    for method in ("get_available_updates", "refresh_available_updates", "apply_updates"):
+        assert not callable(getattr(QnapQtsDriver, method, None)), method